Merged
Conversation
Klakurka
previously approved these changes
Jan 22, 2025
Klakurka
approved these changes
Jan 26, 2025
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
With that last commit I snuck in, works great in all scenarios I could come up with.
chedieck
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #448
Description
Fixed decimals and settleCoin name
Fixed decimals of settleCoin
Test plan
go to sideshift > choose a coin > click
Send with sideshift> set an amount > go back > go backcheck if the amount is set with correct number of decimals.